Skip to content

target: mbedos5: mbed CLI refuses to build if no .mbed file present #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2017
Merged

target: mbedos5: mbed CLI refuses to build if no .mbed file present #1512

merged 1 commit into from
Jan 5, 2017

Conversation

@janjongboom
Copy link
Contributor

@janjongboom janjongboom commented Jan 4, 2017

With the newest release of mbed CLI (1.0.0) it error's when no .mbed file is present in the project root. This breaks builds for JerryScript on mbed OS 5. With this patch we create this file and builds succeed again. We cannot use mbed new because it also creates a new git repository in targets/mbedos5 folder which is not what we want.

JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com

/cc @thegecko @LMESTM @zherczeg @limjunsung

Fixes #1511

@janjongboom
target: mbedos5: mbed CLI refuses to build if no .mbed file present
9caed7a 
With the newest release of mbed CLI (1.0.0) it error's when no .mbed file is present in the project root. This breaks builds for JerryScript on mbed OS 5. With this patch we create this file and builds succeed again. We cannot use `mbed new` because it also creates a new git repository in targets/mbedos5 folder which is not what we want.

JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
@janjongboom janjongboom mentioned this pull request Jan 4, 2017
Closed
@LMESTM
Copy link

LMESTM commented Jan 4, 2017

working fine thx !

@thegecko
Copy link
Contributor

thegecko commented Jan 4, 2017

LGTM

1 similar comment
@zherczeg
Copy link
Member

zherczeg commented Jan 4, 2017

LGTM

@ghost
Copy link

ghost commented Jan 5, 2017

It seems to be working, but the error message still appears...

$ make getlibs

[mbed] ERROR: Could not find mbed program in current path "/Users/limjunsung/jerryscript/targets/mbedos5".
[mbed] ERROR: Change the current directory to a valid mbed program, set the current directory as an mbed program with 'mbed config root .', or use the '--global' option to set global configuration.
echo 'ROOT=.' > .mbed
mbed config root .
[mbed] . now set as default root in program "mbedos5"
mbed toolchain GCC_ARM
[mbed] GCC_ARM now set as default toolchain in program "mbedos5"
mbed target
[mbed] No default target set in program "mbedos5"
mbed deploy
[mbed] WARNING: Program "mbedos5" in "/Users/limjunsung/jerryscript/targets/mbedos5" does not use source control management.
[mbed] WARNING: To fix this you should use "mbed new ." in the root of your program.
[mbed] Adding library "mbed-os" from "https://github.com/ARMmbed/mbed-os" at rev #d5de476f74dd

@thegecko
Copy link
Contributor

thegecko commented Jan 5, 2017

Thanks for the feedback, the output you describe is as expected and is a known limitation of the mbed build system. ARMmbed/mbed-cli#283

LaszloLango
LaszloLango approved these changes Jan 5, 2017
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 8ebbfda into jerryscript-project:master Jan 5, 2017
This was referenced Jan 5, 2017
Open
Closed
janjongboom added a commit to ARMmbed/mbed-js-gulp that referenced this pull request Jan 10, 2017
@janjongboom
Bump JerryScript, make JS on mbed work again with mbed CLI 1.0.0
6d98b88 
See jerryscript-project/jerryscript#1512.

Verified against mbed-js-example and mbed-js-repl-example. My nRF52-DK broke, so I can't verify the BLE stuff...
@janjongboom janjongboom mentioned this pull request Jan 10, 2017
Merged
@zherczeg zherczeg mentioned this pull request Mar 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LaszloLango LaszloLango LaszloLango approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@janjongboom @LMESTM @thegecko @zherczeg @LaszloLango